Improve reusability of widget edit components #20843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linuspahl
force-pushed
the
extend-backend-message-type
branch
2 times, most recently
from
1b6693c to
67870ae
Compare
linuspahl
changed the title
BackendMessage type with timestamp attribute.
linuspahl
force-pushed
the
extend-backend-message-type
branch
4 times, most recently
from
198e277 to
fd167f1
Compare
…dget edit components. Instead we only call `applyAllWidgetChanges` from `WidgetEditApplyAllChangesContext. The `WidgetEditApplyAllChangesProvider` now calls a `onSubmit` prop which takes care of updateing the widget.
linuspahl
force-pushed
the
extend-backend-message-type
branch
from
e16be46 to
29be003
Compare
maxiadlovskii
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is improving the reusability of some widget related component, so they can be reused outside of the search page.
/prd https://github.com/Graylog2/graylog-plugin-enterprise/pull/9261
/nocl