Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input Wizard: Determine first step #20758

Merged
merged 13 commits into from
Nov 8, 2024
Merged

Input Wizard: Determine first step #20758

merged 13 commits into from
Nov 8, 2024

Conversation

grotlue
Copy link
Contributor

@grotlue grotlue commented Oct 22, 2024 •
edited
Loading

Description

Closes #20682
/jpd Graylog2/graylog-plugin-enterprise#9010

This PR adds some logic for determining and setting the first step when opening the wizard. For more detailed information, please see the related issue.

/nocl

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@grotlue grotlue linked an issue Oct 22, 2024 that may be closed by this pull request
Determine first wizard step #20682
Closed
@grotlue grotlue marked this pull request as ready for review October 29, 2024 15:09
@grotlue grotlue requested review from ousmaneo and gally47 October 29, 2024 15:19
gally47
gally47 requested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looking good, wrote some comments below, will test next.

graylog2-web-interface/src/components/inputs/InputSetupWizard/types.ts Show resolved Hide resolved
graylog2-web-interface/src/components/inputs/InputSetupWizard/InputSetupWizard.tsx Show resolved Hide resolved
@gally47 gally47 self-requested a review November 8, 2024 09:51
gally47
gally47 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@gally47 gally47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gally47 gally47 merged commit d3a58b3 into master Nov 8, 2024
7 checks passed
@gally47 gally47 deleted the feat/20682-input-wizard-first-step branch November 8, 2024 09:52
dennisoelkers pushed a commit that referenced this pull request Nov 8, 2024
@grotlue @gally47 @dennisoelkers
Input Wizard: Determine first step (#20758)
28404ea 
* Add missing default props

* Fix eslint

* Add logic to determine first step, cleanup InputWizard logic and files

* Remove update illuminate step

* Move illuminate steps to enterprise

* Add missing license header

* Move category step to enterprise

---------

Co-authored-by: Mohamed OULD HOCINE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gally47 gally47 gally47 approved these changes

@ousmaneo ousmaneo Awaiting requested review from ousmaneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Determine first wizard step
2 participants
@grotlue @gally47