Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka beats implementation #20067

Merged
merged 5 commits into from
Aug 6, 2024
Merged

Kafka beats implementation #20067

merged 5 commits into from
Aug 6, 2024

Conversation

Nithin-Kasam
Copy link
Collaborator

Description

1.Pulls the system logs from Kafka topic by using Filebeats configuration.

Motivation and Context

1.This change eliminates reading the file from remote systems to get system logs, instead we get this logs from kafka topic improving the performance.

How Has This Been Tested?

1.Configured filebeats.yml file in remote system inside same network.
2.Installed kafka,zookeeper and created topic with name configured in filebeats.yml.
3.Started Consumer console and able to see logs from the topic.
4.Created Kafka beats input and verified logs in conusmer console and graylog.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@CLAassistant
Copy link

CLAassistant commented Aug 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ryan-carroll-graylog ryan-carroll-graylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this PR up @Nithin-Kasam! Code looks good to me, glad it looks like we could reuse so much of the existing code.

I plan to get set up for testing this in the next day or two, then I'll add my final review.

@@ -0,0 +1,4 @@
type="a"
message="Display System logs from Kafka topic using file beats"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should specify that this is a new Graylog Input:

Suggested change
message="Display System logs from Kafka topic using file beats"
message="Added new Beats Kafka input to ingest system logs from Kafka topic using Filebeat."

@ryan-carroll-graylog ryan-carroll-graylog self-requested a review August 2, 2024 18:22
Copy link
Contributor

@ryan-carroll-graylog ryan-carroll-graylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good and tests successfully for me, nice work @Nithin-Kasam!

Zack is planning to take a look at this soon too for one more set of eyes, then once he approves we should be good to merge this in.

Copy link
Contributor

@kingzacko1 kingzacko1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work on this.

@ryan-carroll-graylog ryan-carroll-graylog merged commit 1edcd4e into master Aug 6, 2024
5 checks passed
@ryan-carroll-graylog ryan-carroll-graylog deleted the kafka-beats branch August 6, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants