-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka beats implementation #20067
Kafka beats implementation #20067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this PR up @Nithin-Kasam! Code looks good to me, glad it looks like we could reuse so much of the existing code.
I plan to get set up for testing this in the next day or two, then I'll add my final review.
changelog/unreleased/issue-5254.toml
Outdated
@@ -0,0 +1,4 @@ | |||
type="a" | |||
message="Display System logs from Kafka topic using file beats" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should specify that this is a new Graylog Input:
message="Display System logs from Kafka topic using file beats" | |
message="Added new Beats Kafka input to ingest system logs from Kafka topic using Filebeat." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good and tests successfully for me, nice work @Nithin-Kasam!
Zack is planning to take a look at this soon too for one more set of eyes, then once he approves we should be good to merge this in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work on this.
Description
1.Pulls the system logs from Kafka topic by using Filebeats configuration.
Motivation and Context
1.This change eliminates reading the file from remote systems to get system logs, instead we get this logs from kafka topic improving the performance.
How Has This Been Tested?
1.Configured filebeats.yml file in remote system inside same network.
2.Installed kafka,zookeeper and created topic with name configured in filebeats.yml.
3.Started Consumer console and able to see logs from the topic.
4.Created Kafka beats input and verified logs in conusmer console and graylog.
Screenshots (if appropriate):
Types of changes
Checklist: