Add text field attribute to hide sensitive input config #13873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thll
added a commit
that referenced
this pull request
Nov 9, 2022
(cherry picked from commit ee646a4)
thll
added a commit
that referenced
this pull request
Nov 10, 2022
mnin
added a commit
that referenced
this pull request
Nov 10, 2022
* master: Bump @typescript-eslint/parser (#13904) Bump @typescript-eslint/eslint-plugin (#13902) fixed Extractor order can't be changed (#13915) Updating yarn lockfile (#13924) [graylog2-server] prepare for next development iteration Bump package.json version to 5.0.0-SNAPSHOT [graylog2-server] prepare release 5.0.0-beta.3 Bump package.json version to 5.0.0-beta.3 Limits the number of unknown field validation messages (#13923) Bump stylelint (#13907) Bump eslint-plugin-jest (#13903) Bump jest-environment-jsdom (#13920) Bump babel-jest in /graylog2-web-interface/packages/jest-preset-graylog (#13918) Bump jest in /graylog2-web-interface/packages/jest-preset-graylog (#13917) Bump @jest/types in /graylog2-web-interface/packages/jest-preset-graylog (#13919) Add text field attribute to hide sensitive input config (#13873)
bernd
pushed a commit
that referenced
this pull request
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an
is_sensitiveattribute to hide input config in the same way as theis_passwordattribute. Enables masking of sensitive values not only for password fields.Motivation and Context
Closes #13383
How Has This Been Tested?
Set
custom_propertiesin Kafka input config and checked that********on the inputs overview pageinputs:editpermission, the field's value is masked with<value hidden>in the response toGET /api/system/inputsScreenshots (if appropriate):
Types of changes
Checklist: