Improving rendering of TimeRangeDropdown component.
#13554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
refactor/improve-time-range-dropdown-runtime
branch
from
1e56b6e to
7f9adaf
Compare
linuspahl
reviewed
Sep 29, 2022
| @@ -224,6 +255,9 @@ const TimeRangeDropdown = ({ | |||
| </PopoverTitle> | |||
| ); | |||
|
|
|||
| const _validateTimeRange = useCallback(({ nextTimeRange }) => dateTimeValidate(nextTimeRange, limitDuration, formatTime), [formatTime, limitDuration]); | |||
| const initialTimeRange = { nextTimeRange: onInitializingNextTimeRange(currentTimeRange) }; | |||
There was a problem hiding this comment.
Let's use useMemo here as well?
There was a problem hiding this comment.
For sure! I could swear I did that :)
dennisoelkers
force-pushed
the
refactor/improve-time-range-dropdown-runtime
branch
from
1025e31 to
f875c10
Compare
linuspahl
approved these changes
Sep 29, 2022
dennisoelkers
deleted the
refactor/improve-time-range-dropdown-runtime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
In the last weeks, the test for the
TimeRangeDropdowncomponent was running into timeouts repeatedly. In order to address this, the component itself was improved by usages ofuseMemo/useCallbackin order to prevent unnecessary rerenders. On my local machine the test runtime was reduced from 1.2s to 600ms. In addition, a couple of typing issues were addressed.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: