Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autogenerate Sidecar Configuration Path Value #5265

Closed
mpfz0r opened this issue Nov 5, 2018 · 0 comments
Closed

Autogenerate Sidecar Configuration Path Value #5265

mpfz0r opened this issue Nov 5, 2018 · 0 comments
Assignees
@mpfz0r
Labels
improvement sidecar
Milestone
3.0.0

Comments

@mpfz0r
Copy link
Contributor

mpfz0r commented Nov 5, 2018

The decision in our meeting in Hamburg, was to remove the Configuration Path option.
We don't have a strong use case for this feature yet, thus it's better to start with less.

We auto-generate the value instead.
@mpfz0r mpfz0r added this to the 3.0.0 milestone Nov 5, 2018
@mpfz0r mpfz0r self-assigned this Nov 5, 2018
@mpfz0r mpfz0r mentioned this issue Nov 5, 2018
Closed
mpfz0r added a commit that referenced this issue Nov 5, 2018
@mpfz0r
Autogenerate Sidecar collector configuration path
32905a7 
Instead of a GUI option, we autogenerate the path
to ".../generated/<collector_name>.conf"

Remove existing configuration_path values in the migration
to simplify upgrading to this change.

Only expose the configuration path when the Collector object is requested via
the Sidecar API. Change this at runtime to an empty string and
use @JsonInclude(JsonInclude.Include.NON_EMPTY) to hide it.

Fixes #5265
mpfz0r added a commit that referenced this issue Nov 5, 2018
@mpfz0r
Autogenerate Sidecar collector configuration path
559aa8a 
Instead of a GUI option, we autogenerate the path
to ".../generated/<collector_name>.conf"

We still provide the configuration path via the API to the sidecar.
This gives us more flexibility if we need to change the path in the future.

That's why we only expose the configuration path when the Collector object
is requested via the Sidecar API. We can change the path at runtime to an
empty string and use @JsonInclude(JsonInclude.Include.NON_EMPTY) to hide it.

Remove existing configuration_path values in the migration
to simplify upgrading to this change.

Fixes #5265
mpfz0r added a commit to Graylog2/collector-sidecar that referenced this issue Nov 8, 2018
@mpfz0r
Generate collector configuration file path in sidecar
a5c1684 
Add a new sidecar.yml config option 'collector_config_directory'
to allow the configurations to be rendered into a different directory.

In the future, graylog might be able to specify the file name
for each collector backend. Add support for that by
adding a 'configuration_file_name' field to the API.

Fixes Graylog2/graylog2-server#5265
mpfz0r added a commit that referenced this issue Nov 8, 2018
@mpfz0r
Remove Sidecar collector configuration path
5b601d6 
Instead of a GUI option, we let the sidecar autogenerate the path
to ".../generated/<collector_name>.conf"

Remove existing configuration_path values in the migration
to simplify upgrading to this change.

Fixes #5265
@mpfz0r mpfz0r mentioned this issue Nov 8, 2018
Merged
mpfz0r added a commit that referenced this issue Nov 8, 2018
@mpfz0r
Remove Sidecar collector configuration path
2742fa1 
Instead of a GUI option, we let the sidecar autogenerate the path
to ".../generated/<collector_name>.conf"

Remove existing configuration_path values in the migration
to simplify upgrading to this change.

Fixes #5265
mariussturm pushed a commit to Graylog2/collector-sidecar that referenced this issue Nov 13, 2018
@mpfz0r
Generate collector configuration file path in sidecar (#307)
a2eb2be 
* Generate collector configuration file path in sidecar

Add a new sidecar.yml config option 'collector_config_directory'
to allow the configurations to be rendered into a different directory.

In the future, graylog might be able to specify the file name
for each collector backend. Add support for that by
adding a 'configuration_file_name' field to the API.

Fixes Graylog2/graylog2-server#5265

* Fix review comments

* Replace more "config" with "configuration"
mpfz0r added a commit that referenced this issue Nov 13, 2018
@mpfz0r
Remove Sidecar collector configuration path
bc5eb8d 
Instead of a GUI option, we let the sidecar autogenerate the path
to ".../generated/<collector_name>.conf"

Remove existing configuration_path values in the migration
to simplify upgrading to this change.

Fixes #5265
mariussturm pushed a commit that referenced this issue Nov 14, 2018
@mpfz0r
Remove Sidecar collector configuration path (#5278)
7127802 
* Remove Sidecar collector configuration path

Instead of a GUI option, we let the sidecar autogenerate the path
to ".../generated/<collector_name>.conf"

Remove existing configuration_path values in the migration
to simplify upgrading to this change.

Fixes #5265

* Restrict collector names to path safe characters

We use the collector name in the configuration path.
Avoid problems by restricting it to a characters that need no escape
handling.

* Perform validatons all collector requests

and fix annotation on copy route

* Remove debug printf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpfz0r mpfz0r

Labels
improvement sidecar
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@mpfz0r