Bump com.google.errorprone:error_prone_core from 2.35.1 to 2.36.0 (#2…

…0990)

* Bump com.google.errorprone:error_prone_core from 2.35.1 to 2.36.0

Bumps [com.google.errorprone:error_prone_core](https://github.com/google/error-prone) from 2.35.1 to 2.36.0.
- [Release notes](https://github.com/google/error-prone/releases)
- [Commits](google/error-prone@v2.35.1...v2.36.0)

---
updated-dependencies:
- dependency-name: com.google.errorprone:error_prone_core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Add --should-stop=ifError=FLOW argument for error-prone

The flag is documented for setting error-prone up for Maven. Somehow we
missed the flag.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bernd Ahlers <[email protected]>
Co-authored-by: Bernd Ahlers <[email protected]>

pom.xml

@@ -116,7 +116,7 @@
         <commons-validator.version>1.9.0</commons-validator.version>
         <commons-io.version>2.18.0</commons-io.version>
         <disruptor.version>4.0.0</disruptor.version>
-        <error-prone.version>2.35.1</error-prone.version>
+        <error-prone.version>2.36.0</error-prone.version>
         <freemarker.version>2.3.33</freemarker.version>
         <gelfclient.version>1.5.1</gelfclient.version>
         <geoip2.version>4.2.1</geoip2.version>
@@ -923,6 +923,7 @@
                     <forceJavacCompilerUse>true</forceJavacCompilerUse>
                     <compilerArgs>
                         <arg>-XDcompilePolicy=simple</arg>
+                        <arg>--should-stop=ifError=FLOW</arg>
                         <!--
                           We disabled checks that don't apply to us because we either don't use the platform or
                           library. (e.g., Android, Flogger) Disabling those checks improves compile times.