Skip to content
This repository has been archived by the owner on Oct 27, 2021. It is now read-only.

Update Sidecar requirements documentation. #1100

Merged
merged 3 commits into from
Mar 11, 2021
Merged

Update Sidecar requirements documentation. #1100

merged 3 commits into from
Mar 11, 2021

Conversation

malcyon
Copy link
Contributor

@malcyon malcyon commented Mar 3, 2021

I have not released Graylog Sidecar 1.1.0 yet, but when I do, I'd like the documentation to be clear on the new server requirements (See Graylog2/collector-sidecar#391).

This should not be merged yet (not until Sidecar 1.1.0 is released). But I would like feedback on how clear this looks. Does it make sense?

I think the idea is that if Sidecar installs Beats 7.0, that older versions of Graylog won't work with it.

@malcyon malcyon requested review from mpfz0r and dulanism March 3, 2021 19:09
pages/sidecar.rst Outdated Show resolved Hide resolved
@mpfz0r
Copy link
Contributor

mpfz0r commented Mar 3, 2021

I think the idea is that if Sidecar installs Beats 7.0, that older versions of Graylog won't work with it.

Just to clarify:
This isn't really a sidecar incompatibility, but a beats one.
It only affects the Windows sidecar, because that's the only one where we are shipping the beats binaries.
On Linux, users are responsible themselves to install beats. And they could've already updated beats to 7.x and experienced problems.

And I'm not suggesting we should document any of that ;-)

@malcyon
Copy link
Contributor Author

malcyon commented Mar 3, 2021

@mpfz0r Thanks for the clarification!

@malcyon malcyon requested a review from mpfz0r March 3, 2021 19:32
Copy link
Contributor

@mpfz0r mpfz0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I guess we should also apply that change to the older doc branches. like at least 3.3 and 3.2.

@malcyon
Copy link
Contributor Author

malcyon commented Mar 3, 2021

Looks good. I guess we should also apply that change to the older doc branches. like at least 3.3 and 3.2.

Right. I'll take care of that, too.

Copy link
Contributor

@dulanism dulanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thank you, @juju2112

@malcyon malcyon merged commit 5045588 into 4.0 Mar 11, 2021
@malcyon malcyon deleted the sidecar/1.0.3 branch March 11, 2021 20:41
malcyon pushed a commit that referenced this pull request Mar 11, 2021
* Update sidecar requirements to reflect Graylog2/collector-sidecar#391.

* Fix sidecar version in requirements matrix.

* Update versions in matrix for clarity.

(cherry picked from commit 5045588)
malcyon pushed a commit that referenced this pull request Mar 11, 2021
* Update sidecar requirements to reflect Graylog2/collector-sidecar#391.

* Fix sidecar version in requirements matrix.

* Update versions in matrix for clarity.

(cherry picked from commit 5045588)
mpfz0r pushed a commit that referenced this pull request Mar 12, 2021
* Update sidecar requirements to reflect Graylog2/collector-sidecar#391.

* Fix sidecar version in requirements matrix.

* Update versions in matrix for clarity.

(cherry picked from commit 5045588)
mpfz0r pushed a commit that referenced this pull request Mar 12, 2021
* Update sidecar requirements to reflect Graylog2/collector-sidecar#391.

* Fix sidecar version in requirements matrix.

* Update versions in matrix for clarity.

(cherry picked from commit 5045588)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants