Code

Improve process shutdown handling#462

Code

Merged

mpfz0r merged 22 commits intomasterGraylog2/collector-sidecar:masterfrom fix/restart-loopGraylog2/collector-sidecar:fix/restart-loopCopy head branch name to clipboardJan 12, 2023

+238-76

Commits

Commits on Jan 3, 2023

• Improve process shutdown handling

  Show description for 8d90c8b
  mpfz0r

  committed
  8d90c8b

• remove stale code

  mpfz0r

  committed
  9c66d67

• Fix build for windows

  Show description for ecc35a7
  mpfz0r

  committed
  ecc35a7

• Don't log wait errors as a warning

  mpfz0r

  committed
  ef02ced

Commits on Jan 4, 2023

• Improve restart behaviour for hanging collectors

  Show description for 9393693
  mpfz0r

  committed
  9393693

• Don't prevent sidecar from shutting down with hanging collectors

  Show description for 8b00166
  mpfz0r

  committed
  8b00166

Commits on Jan 5, 2023

• Adjust timeouts

  Show description for 0a70658
  mpfz0r

  committed
  0a70658

Commits on Jan 9, 2023

• Refactor KillProcess

  Show description for e37056b
  

  mpfz0r

  and

  bernd

  committed
  e37056b

• be less verbose

  mpfz0r

  committed
  c102f5e

• Sleep a tiny bit after we send SIGKILL

  Show description for 049b101
  mpfz0r

  committed
  049b101

• log if we finally failed to stop the process

  mpfz0r

  committed
  b38b85b

• Remove second wait loop in restart

  Show description for 024980c
  mpfz0r

  committed
  024980c

• Move cmd.Wait() abortion into stop()

  Show description for e9fc465
  mpfz0r

  committed
  e9fc465

• Make collector shutdown timeout configurable

  Show description for 4aab929
  mpfz0r

  committed
  4aab929

• Determine backend stopped status in wait goroutine

  mpfz0r

  committed
  3bbe855

• read termination ack

  mpfz0r

  committed
  be24a0d

• Add changelog

  mpfz0r

  committed
  59e1cc7

Commits on Jan 10, 2023

• Change log statements from Infof to Warnf

  bernd

  committed
  298bd7c

• Moar changelogs

  mpfz0r

  committed
  a8a1c39

• add dots

  mpfz0r

  committed
  8b8db9e

Commits on Jan 11, 2023

• Improve log message formatting

  bernd

  committed
  cb9b378

• Remove timout from sidecar shutdown routine

  Show description for 9c588ac
  mpfz0r

  committed
  9c588ac