Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mac M1 sidecar build #428

Merged
merged 5 commits into from
May 18, 2022
Merged

Add Mac M1 sidecar build #428

merged 5 commits into from
May 18, 2022

Conversation

mpfz0r
Copy link
Contributor

@mpfz0r mpfz0r commented May 18, 2022

Notes for Reviewers

  • The commit history must be preserved - please use the rebase-merge or standard merge option instead of squash-merge
  • Sync up with the author before merging

mpfz0r added 2 commits May 18, 2022 10:32
Rename it to resource_windows.syso so it does not conflict with other
archicture builds
@mpfz0r mpfz0r requested a review from thll May 18, 2022 09:06
@mpfz0r
Copy link
Contributor Author

mpfz0r commented May 18, 2022

FYI: @kodjo-anipah successfully tested this already 👍

@thll thll self-assigned this May 18, 2022
mpfz0r added 2 commits May 18, 2022 14:19
```
The -i build flag
The -i flag accepted by go build, go install, and go test is now deprecated. The -i flag instructs the go command to install packages imported by packages named on the command line. Since the build cache was introduced in Go 1.10, the -i flag no longer has a significant effect on build times, and it causes errors when the install directory is not writable.
```
Co-authored-by: Othello Maurer <[email protected]>
Copy link
Contributor

@thll thll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Didn't test the binary itself, but it builds nicely 😄

@thll thll merged commit ef91c48 into master May 18, 2022
@thll thll deleted the m1-mac-sidecar branch May 18, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants