Parameter rename #400
Merged
Parameter rename #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcyon
suggested changes
Jan 6, 2021
There was a problem hiding this comment.
Doesn't compile for Windows.
[2021-01-06T13:36:35.283Z] daemon/svc_runner_windows.go:123:18: r.RunnerCommon.backend.CheckExecutableAgainstWhitelist undefined (type backends.Backend has no field or method CheckExecutableAgainstWhitelist)
[2021-01-06T13:36:35.283Z] Makefile:70: recipe for target 'build-windows' failed
[2021-01-06T13:36:35.283Z] make: *** [build-windows] Error 2
script returned exit code 2
I think you missed:
https://github.com/Graylog2/collector-sidecar/blob/master/daemon/svc_runner_windows.go#L123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here Graylog2/graylog2-server#8320 we are going to change certain vocabulary in the product. This PR is changing
collector_binaries_whitelisttocollector_binaries_accesslist. The change should be backward compatible and print a warning about the deprecated use of a configuration option./cc @kyleknighted
While doing this I noticed that the switch to
go modwas pulling in a lot of not used modules. This is because 3rd party source code in/distwas scanned. This directory is ignored now and should fix the build.