Wipe configchecksums also on assignment changes (backport) #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an assignemnt is changed to switch a backend from one configuration to another, we would still send configuration requests using the old checksum. The server will respond with `NotModified` and we don't try to restart the backend. Instead of also resetting the checksum when we update the assignment store, simply wipe the entire checksum map if either the assignment or the backends have changed. Fixes #352 (cherry picked from commit dca0b17)
mariussturm
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an assignment is changed to switch a backend from
one configuration to another, we would still send configuration requests
using the old checksum.
The server will respond with
NotModifiedand we don't try to restartthe backend.
Instead of also resetting the checksum when we update the assignment
store, simply wipe the entire checksum map if either the assignment
or the backends have changed.
Fixes #352
Also bump version to 1.0.1