Default the windows installer to an empty nodename #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a better default to use the system's hostname. Fixes #339
mariussturm
approved these changes
Mar 6, 2019
mpfz0r
added a commit
that referenced
this pull request
Aug 13, 2019
mariussturm
pushed a commit
that referenced
this pull request
Aug 13, 2019
* Stop setting default node name to graylog-sidecar (#346) Removed the lines to default the node name to graylog-sidecar. The current action doesn't match the documentation. # The node name of the sidecar. If this is empty, the sidecar will use the # hostname of the host it is running on. (cherry picked from commit b7c0048) * Default the windows installer to an empty nodename (#347) It's a better default to use the system's hostname. Fixes #339 (cherry picked from commit 5472b0d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a better default to use the system's hostname.
Fixes #339