Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collector_whitelist feature #284

Merged
merged 2 commits into from
Sep 11, 2018
Merged

Fix collector_whitelist feature #284

merged 2 commits into from
Sep 11, 2018

Conversation

mariussturm
Copy link
Contributor

Fix file existing check. Inverse if logic and return in case the file doesn't exist.

See #279 (comment)

The previous fix for #279 introduced an error,
because result.Path was not always set.

Instead of failing on non-existant files, still perform the PathMatch
but report them in result.DoesExist.

Broken symlinks are always reported as an error, because we cannot
resolve their actual path using EvalSymlinks.

Add some tests.

Fixes #279
@mariussturm mariussturm merged commit c5a6eda into master Sep 11, 2018
@mariussturm mariussturm deleted the issue-279-2 branch September 11, 2018 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants