Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust and document example configs #252

Merged
merged 4 commits into from
Jul 6, 2018
Merged

Adjust and document example configs #252

merged 4 commits into from
Jul 6, 2018

Conversation

bernd
Copy link
Member

@bernd bernd commented Jul 6, 2018

This changes the example configurations to match the new config options. I also documented every config option in the example files to make it easier for the user.

Changes:

  • Rename config option "api_token" "server_api_token"
  • Adjust windows installer for changed and removed config options
    • Rename NODEID to NODENAME
    • Remove tag related options
    • Remove collector related options
  • Adjust and document configuration settings
  • Rename example config files to make it explicit that they are examples

@bernd bernd added this to the 3.0.0 milestone Jul 6, 2018
@bernd bernd requested a review from mariussturm July 6, 2018 08:37
mariussturm
mariussturm approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@mariussturm mariussturm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariussturm mariussturm merged commit 3043076 into master Jul 6, 2018
@mariussturm mariussturm deleted the adjust-and-document-example-config branch July 6, 2018 10:36
mpfz0r added a commit that referenced this pull request Sep 21, 2018
@mpfz0r
Update README to reality; s/Graylog-sidecar.exe/graylog-sidecar.exe
1dfb456 
 - Add APITOKEN option
 - Clean up after #252
 - lowercase windows executable name
mariussturm pushed a commit that referenced this pull request Sep 21, 2018
@mpfz0r
Have the Windows installer ask for the API token (#295)
901bc97 
* Have the Windows installer ask for the API token

Fixes #288

* Update README to reality; s/Graylog-sidecar.exe/graylog-sidecar.exe

 - Add APITOKEN option
 - Clean up after #252
 - lowercase windows executable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariussturm mariussturm mariussturm approved these changes

Assignees
No one assigned
Labels
ready-for-review
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bernd @mariussturm