Unified Windows installer + passing the version number to nsis phase #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, two points:
|
mariussturm
reviewed
Nov 14, 2016
| @@ -42,22 +38,14 @@ | |||
| Var Tags | |||
| Var Dialog | |||
| Var Label | |||
| Var Graylog_dir | |||
There was a problem hiding this comment.
This should be called GraylogDir
There was a problem hiding this comment.
OK, I'm changing it ;-)
|
The currently supported collectors (Filebeat, Winlogbeat and NXlog) are 32 bit only. But you are right, in order to support new collectors' versions you'll have to change the nsis source - along with dist/fetch_collectors.sh. But this should be easy now, maybe I could already prepare the support for the 64 bit collectors that are present in *beat 5.0. |
|
Ok great, will merge this for now. The 32/64bit binary support is needed when the beats5 support is merged into the sidecar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
32 and 64 bit executables are now packaged inside a single Windows installer called _X86 - but only the right one will be copied at runtime.
Also, the build number is now obtained from the Makefile (which in turn gets it from github).