Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling the whitelist doesn't work anymore #327

Closed
bernd opened this issue Jan 9, 2019 · 0 comments
Closed

Disabling the whitelist doesn't work anymore #327

bernd opened this issue Jan 9, 2019 · 0 comments
Labels
bug #S <= 1d
Milestone
3.0.0

Comments

@bernd
Copy link
Member

bernd commented Jan 9, 2019

Problem description

I tried to set the collector_binaries_whitelist config option to an empty value to allow all binaries. This doesn't seem to work anymore. It used to work with 1.0.0-alpha.9 but doesn't work with 1.0.0.beta.1 anymore.

Jan 09 16:12:55 box2 graylog-sidecar[26792]: time="2019-01-09T16:12:55+01:00" level=info msg="[journalbeat-6.5.4] Configuration change detected, rewriting configuration file."
Jan 09 16:12:55 box2 graylog-sidecar[26792]: time="2019-01-09T16:12:55+01:00" level=error msg="[journalbeat-6.5.4] Couldn't execute collector /opt/beats/journalbeat-6.5.4/journalbeat, binary path is not included in `collector_binaries_whitelist' config option."

Steps to reproduce the problem

  1. Set collector_binaries_whitelist: (empty value)
  2. Restart the sidecar
  3. Check logs and see that collectors cannot be started because they are not in the whitelist.

Environment

  • Sidecar Version: 1.0.0-beta.1
@bernd bernd added bug #S <= 1d labels Jan 9, 2019
@bernd bernd added this to the 3.0.0 milestone Jan 9, 2019
mpfz0r added a commit that referenced this issue Jan 9, 2019
@mpfz0r
Fix configuration parsing of lists
bfe5dca 
Don't use `ucfg.Merge` because this will merge the contents
of two slices by copying them on top of each other.

Use a much simpler approach and just join the configuration
strings together before parsing them.

Fixes #327
@mpfz0r mpfz0r mentioned this issue Jan 9, 2019
Merged
bernd pushed a commit that referenced this issue Jan 10, 2019
@mpfz0r @bernd
Fix configuration parsing of lists (#328)
ce69678 
* Fix configuration parsing of lists

Don't use `ucfg.Merge` because this will merge the contents
of two slices by copying them on top of each other.

Use a much simpler approach and just join the configuration
strings together before parsing them.

Fixes #327

* Handle configurations with yaml doc separators

Yaml doc separators would get in the way of merging the configuration
with the default.

* Be more explicit about empty lists in the configuration
mpfz0r added a commit that referenced this issue Jan 10, 2019
@mpfz0r
Improve yaml doc seperator match
6a92def 
According to the yaml spec, the seperator can have
"a line break or a sequence of space characters"

Fixes #327
@mpfz0r mpfz0r mentioned this issue Jan 10, 2019
Merged
bernd pushed a commit that referenced this issue Jan 10, 2019
@mpfz0r @bernd
Improve yaml doc seperator match (#329)
f5388d8 
According to the yaml spec, the seperator can have
"a line break or a sequence of space characters"

Fixes #327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug #S <= 1d
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@bernd