Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collector status shows as "invalid configuration file" when collector executable does not exist #311

Closed
lennartkoopmann opened this issue Nov 24, 2018 · 0 comments
Closed

Collector status shows as "invalid configuration file" when collector executable does not exist #311

lennartkoopmann opened this issue Nov 24, 2018 · 0 comments
Assignees
@mpfz0r
Labels
blocker If not finished by release date, the release will be postponed. bug
Milestone
3.0.0

Comments

@lennartkoopmann
Copy link

I applied a metricbeat confiugration to a host that did not have metricbeat installed yet and the status showed like this:

2018-11-24_17-29

The sidecar log showed this:

time="2018-11-24T23:25:43Z" level=info msg="Starting signal distributor" 
time="2018-11-24T23:25:53Z" level=info msg="Adding process runner for: metricbeat" 
time="2018-11-24T23:25:53Z" level=info msg="[metricbeat] Configuration change detected, rewriting configuration file." 
time="2018-11-24T23:25:53Z" level=error msg="[metricbeat] Couldn't start validation command:  fork/exec /usr/bin/metricbeat: no such file or directory" 
time="2018-11-24T23:25:53Z" level=error msg="[metricbeat] Collector configuration file is not valid, waiting for the next update."

After installing metricbeat (and restarting sidecar?!) the error disappeared and the status switched to "Collector is running".

I think it should show /usr/bin/metricbeat: no such file or directory in the web interface instead.
@lennartkoopmann lennartkoopmann added bug blocker If not finished by release date, the release will be postponed. labels Nov 24, 2018
@lennartkoopmann lennartkoopmann added this to the 3.0.0 milestone Nov 24, 2018
@mpfz0r mpfz0r self-assigned this Nov 26, 2018
mpfz0r added a commit that referenced this issue Nov 26, 2018
@mpfz0r
Improve collector validation error messages
5350366 
Change the ValidateConfigurationFile function to return errors instead of a boolean.
This allows for more specific error messages in the user interface.

Fixes #311
@mpfz0r mpfz0r mentioned this issue Nov 26, 2018
Merged
mariussturm pushed a commit that referenced this issue Nov 30, 2018
@mpfz0r
Improve collector validation error messages (#312)
eda0771 
Change the ValidateConfigurationFile function to return errors instead of a boolean.
This allows for more specific error messages in the user interface.

Fixes #311
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpfz0r mpfz0r

Labels
blocker If not finished by release date, the release will be postponed. bug
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@lennartkoopmann @mpfz0r