Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collector Sidecar should exit if node ID is empty #253

Closed
joschi opened this issue Jul 6, 2018 · 0 comments
Closed

Collector Sidecar should exit if node ID is empty #253

joschi opened this issue Jul 6, 2018 · 0 comments
Milestone

Comments

@joschi
Copy link
Contributor

joschi commented Jul 6, 2018

Problem description

The Collector Sidecar tries to generate a unique node ID, use a given unique node ID, or fallback to the hostname to identify itself with Graylog.

Under some (unclear?) circumstances, the node ID might be empty or blank which leads to errors when requesting configuration from Graylog.

As a part of the bootstrap checks, the Collector Sidecar should check for invalid node IDs and exit with a non-zero exit code if the node ID is invalid.

https://github.com/Graylog2/collector-sidecar/blob/0.1.6/context/context.go#L69-L76
https://github.com/Graylog2/collector-sidecar/blob/1.0.0-alpha.2/context/context.go#L73-L81

Refs https://community.graylog.org/t/unable-to-run-collector-sidecar/5883

Environment

  • Sidecar Version: 0.16 (probably also 1.0.0-alpha.2)
  • Graylog Version: 2.4.5 (probably also 3.0.0-XXX)
@joschi joschi added the bug label Jul 6, 2018
@bernd bernd added this to the 3.0.0 milestone Jul 6, 2018
@joschi joschi added the triaged label Jul 9, 2018
bernd pushed a commit that referenced this issue Jul 12, 2018
Fixes #253 

(cherry picked from commit 94d2a4e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants