Update Wasm dependencies to fix WebGPU spec change crash in Firefox with Vello #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
force-pushed
the
update-wasm-deps
branch
from
a9698b4 to
6f466a2
Compare
Keavon
force-pushed
the
update-wasm-deps
branch
from
f4533cf to
476f71e
Compare
Keavon
changed the title
|
It sounds like next week is when WGPU 0.23 is planned for release. I'll go ahead and merge this now but we should be able to update as soon as that comes out and Vello pushes an upgrade to it, letting us switch to the released WGPU and the official Git version of Vello instead of needing to use the Vello fork for now. But that'll all be an easy followup PR next week. |
Keavon
approved these changes
Oct 11, 2024
Keavon
requested changes
Oct 11, 2024
0HyperCube
force-pushed
the
update-wasm-deps
branch
from
476f71e to
37fc0f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes running on firefox nightly (requires the latest wgpu to fix gfx-rs/wgpu#6290 (comment)). This also required using vello with the git wgpu version.
We get a warning due to "use of deprecated method
web_sys::CanvasRenderingContext2d::set_stroke_style". There is an alternative function but it is broken. I fixed it in rustwasm/wasm-bindgen#4170 but it has not been released. There will apparently be a patch release "today".