feat: add onOperationComplete & onOperationError callbacks #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NeedleInAJayStack This should allow for unsubscribe handling |
|
@NeedleInAJayStack Let me know if you think this looks like a more complete system. I added in an |
GNMoseke
changed the title
Comment on lines
21
to
22
| var onOperationComplete: () -> Void = {} | ||
| var onOperationError: () -> Void = {} |
There was a problem hiding this comment.
It would be convenient for both of these to provide the ID of the operation that has completed or errored.
| @@ -64,6 +66,7 @@ public class Server<InitPayload: Equatable & Codable> { | |||
| return | |||
| } | |||
|
|
|||
| // handle incoing message | |||
There was a problem hiding this comment.
Fix incoing to incoming
| @@ -6,7 +6,7 @@ import GraphQLRxSwift | |||
| import NIO | |||
| import RxSwift | |||
|
|
|||
| /// Server implements the server-side portion of the protocol, allowing a few callbacks for customization. | |||
| /// Server implements the server-side portion of the protocol, allowing a few callbacks for customization. 0 or 1 subscriptions per connection and no more. | |||
There was a problem hiding this comment.
Why do we specify 0 or 1 subscription? I believe it can support any number of subscriptions, as long as they have different IDs.
There was a problem hiding this comment.
This was just an incorrect assumption by me that I forgot to remove. Removed now.
NeedleInAJayStack
approved these changes
Jul 23, 2022
NeedleInAJayStack
added a commit
that referenced
this pull request
Jan 10, 2025
Chore: Pull base changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an onComplete callback & registration function for configuring behavior when the server receives a
completemessage