Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building from source with user-specified GraphBLAS #85

Merged
merged 2 commits into from
May 3, 2023

Conversation

alugowski
Copy link
Collaborator

Look for GraphBLAS first in GraphBLAS_ROOT env var, if empty then fallback to current paths.

using GraphBLAS_ROOT because that's what CMake expects when building against GraphBLAS in C++.

fixes #79

Look for GraphBLAS first in GraphBLAS_ROOT env var, if empty then fallback to current paths
@eriknw
Copy link
Member

eriknw commented May 3, 2023

Thanks @alugowski! I'm going to give this a try locally and will let you know how it goes.

Btw, we do squash merges by default, so there is little need to rebase and force push to change history (but you can still do so if you want).

@eriknw
Copy link
Member

eriknw commented May 3, 2023

Great, this works for me!

The graphblas shared objects also need to be findable at runtime. If SuiteSparse:GraphBLAS is installed in a non-standard location, this probably requires LD_LIBRARY_PATH to be set appropriately. I'm not sure if this is worth mentioning in the readme (if a user is compiling from source, they probably know this).

@alugowski
Copy link
Collaborator Author

Good point, LD_LIBRARY_PATH is easy to forget about.

If this is a common use then supporting static linking may be useful. Fewer frictions for the end user is always better.

@eriknw
Copy link
Member

eriknw commented May 3, 2023

Thanks for the quick update, this looks great to me!

I'd rather leave worrying about static linking for another day ;)

Merging and then doing an alpha release to test things out 🤞 🚀

@alugowski
Copy link
Collaborator Author

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to install python-suitesparse-graphblas with pre-installed SuiteSparse:GraphBLAS
2 participants