Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SuiteSparse:GraphBLAS 8.2.1 #110

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Update to SuiteSparse:GraphBLAS 8.2.1 #110

merged 2 commits into from
Oct 13, 2023

Conversation

eriknw
Copy link
Member

@eriknw eriknw commented Oct 13, 2023

Also, hopefully fix #109 by changing release trigger to "published", not "created".

@alugowski
Copy link
Collaborator

Good catch! So the workflow was being triggered on release "create" but the upload was only enabled for "publish".

@eriknw
Copy link
Member Author

eriknw commented Oct 13, 2023

Yup! I think "published" is the right one to use, which you reasonably did in the if condition:
https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=published#release

New release coming up 🤞

@eriknw
Copy link
Member Author

eriknw commented Oct 13, 2023

Why? 😭

 build/temp.macosx-11.0-arm64-cpython-38/suitesparse_graphblas._graphblas.c:570:10: fatal error: 'GraphBLAS.h' file not found

https://github.com/GraphBLAS/python-suitesparse-graphblas/actions/runs/6513170637/job/17692251398?pr=110#step:8:1615

@eriknw
Copy link
Member Author

eriknw commented Oct 13, 2023

I see, the brew fetch failed in add_arm_to_libomp_dylib.sh. Retry should hopefully fix.

@eriknw
Copy link
Member Author

eriknw commented Oct 13, 2023

@alugowski do you know how to add retries to brew commands? A quick search left me even more confused. Network in CI can be flaky, so it would be nice to make our commands more resilient.

@eriknw
Copy link
Member Author

eriknw commented Oct 13, 2023

Even though it's a little slower and adds some noise, I really like building wheels for PRs!

@eriknw eriknw merged commit 0b92b85 into GraphBLAS:main Oct 13, 2023
@alugowski
Copy link
Collaborator

@alugowski do you know how to add retries to brew commands? A quick search left me even more confused. Network in CI can be flaky, so it would be nice to make our commands more resilient.

Looks like the --retry switch does that:

       --retry
              Retry if downloading fails or re-download if the checksum of a previously cached version no longer matches. Tries at most 5 times with exponential backoff.

We can also add a "|| exit 1" on the script invocation to fail fast. I can make a PR.

@alugowski
Copy link
Collaborator

Even though it's a little slower and adds some noise, I really like building wheels for PRs!

Agreed!

@alugowski
Copy link
Collaborator

I recently discovered you can add input options to manual workflow dispatch. So I experimented with such an input to control PyPI upload:

image

Would you like it to be added here? That way if a workflow run fails for an ephemeral reason then it can be rerun manually.

@alugowski
Copy link
Collaborator

@alugowski do you know how to add retries to brew commands? A quick search left me even more confused. Network in CI can be flaky, so it would be nice to make our commands more resilient.

#111

@alugowski
Copy link
Collaborator

I recently discovered you can add input options to manual workflow dispatch. So I experimented with such an input to control PyPI upload:
image

Would you like it to be added here? That way if a workflow run fails for an ephemeral reason then it can be rerun manually.

#112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Artifacts not uploaded to PyPI upon release
2 participants