Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add musllinux wheels #106

Merged
merged 7 commits into from
Oct 6, 2023
Merged

Add musllinux wheels #106

merged 7 commits into from
Oct 6, 2023

Conversation

alugowski
Copy link
Collaborator

Based on #105. This PR adds one commit on top of that PR.

Add musllinux wheels.

Using separate runner mostly for speed. The musl build ends up compiling numpy from source for most Python versions because oldest-supported-numpy does not discriminate by libc version and installs a version older than 1.25 (the first numpy with musl wheels). The separate runner also enables libgraphblas to be built against Musl and not glibc.

@eriknw
Copy link
Member

eriknw commented Oct 6, 2023

oops, sorry, I did a squash merge without thinking in #105, which lost the shared history with this PR and now there's a conflict that needs resolved.

@eriknw
Copy link
Member

eriknw commented Oct 6, 2023

LGTM! This now gives us full coverage of the same wheels that NumPy provides except for win32, which I think is the best we can hope for.

@eriknw eriknw merged commit fc4d14d into GraphBLAS:main Oct 6, 2023
24 checks passed
@alugowski
Copy link
Collaborator Author

LGTM! This now gives us full coverage of the same wheels that NumPy provides except for win32, which I think is the best we can hope for.

Yes.

The SciPy folks are looking for excuses to drop wheels for 32-bit platforms, though I imagine numpy will keep them longer than scipy will.

@alugowski alugowski deleted the musl branch October 7, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants