Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PyPy wheels work #100

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Make PyPy wheels work #100

merged 2 commits into from
Oct 5, 2023

Conversation

alugowski
Copy link
Collaborator

@alugowski alugowski commented Oct 3, 2023

Make PyPy wheels work.

  • Fix PyPy 3.9 build by following SciPy's approach. oldest-supported-numpy only works for CPython. That same version is unsupported on PyPy. SciPy uses an unpinned numpy version on PyPy so pip will download a working version.
  • Skip PyPy 3.10 because numpy does not support it.
  • PyPy 3.8 works by building numpy from source. Since it works, let it be.

Example Actions run (only PyPy enabled in this special run, with a hacked SS version hence why only macOS succeeds): https://github.com/alugowski/python-suitesparse-graphblas/actions/runs/6388091525/job/17337388925

@alugowski
Copy link
Collaborator Author

FYI scipy/oldest-supported-numpy#78 would make the first bullet point redundant and unnecessary.

@eriknw eriknw merged commit cdc1a5c into GraphBLAS:main Oct 5, 2023
13 checks passed
@alugowski alugowski deleted the pypywheel branch October 7, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants