Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: Use the same format when we're in INFO / DEBUG mode #857

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

Jongy
Copy link
Contributor

@Jongy Jongy commented Nov 9, 2023

It's nicer when gprofiler: is always included, and generally it's nicer to have the same format for file / stdout.

@Jongy Jongy added the enhancement New feature or request label Nov 9, 2023
@Jongy Jongy requested a review from d3dave November 9, 2023 14:38
@Jongy
Copy link
Contributor Author

Jongy commented Nov 9, 2023

------
 > [node-package-builder-musl 6/6] RUN ./build_node_package.sh:
10.37 gyp ERR! stack at require (internal/modules/cjs/helpers.js:107:18)
10.37 gyp ERR! stack at Object.acc.<computed> [as install] (/usr/local/lib/node_modules/node-gyp/lib/node-gyp.js:80:32)
10.37 gyp ERR! stack at getNodeDir (/usr/local/lib/node_modules/node-gyp/lib/configure.js:53:26)
10.37 gyp ERR! stack at configure (/usr/local/lib/node_modules/node-gyp/lib/configure.js:24:10)
10.37 gyp ERR! System Linux 6.2.0-1015-azure
10.37 gyp ERR! command "/usr/bin/node" "/usr/local/bin/node-gyp" "configure" "--target=10.10.0" "--build_v8_with_gn=false"
10.37 gyp ERR! cwd /tmp/module
10.37 gyp ERR! node -v v14.21.3
10.37 gyp ERR! node-gyp -v v10.0.1
10.37 gyp ERR! not ok 
------
executable.Dockerfile:112
--------------------
 110 |     RUN ./node_builder_musl_env.sh
 111 |     COPY scripts/build_node_package.sh .
 112 | >>> RUN ./build_node_package.sh
 113 |     
 114 |     # building bcc along with helpers
--------------------

bleh, will fix in a different PR

d3dave
d3dave previously approved these changes Nov 9, 2023
node-gyp 10.x.x was released recently, and our build started failing with this error:

	16.93 gyp ERR! configure error
	16.93 gyp ERR! stack TypeError: Cannot read property 'pipeline' of undefined

Pinning to 9.x.x helps.
@Jongy
Copy link
Contributor Author

Jongy commented Nov 22, 2023

Merged #858 so the build will pass and the tests run.

@Jongy Jongy merged commit bcf06b4 into master Nov 23, 2023
28 checks passed
@Jongy Jongy deleted the normalized-message-format branch November 23, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants