Simplified the code of GOButtonCreator #2130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg68
changed the title
oleg68
force-pushed
the
refactor/create-buttons
branch
from
7e7fc07 to
219b23c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the code of GOButtonCreator a little bit simpler.
Earlier there was a virtual method GetButtonDefinitionList() that returned button definitions. GOButtonCreator::CreateButtons was calling GetButtonDefinitionList().
Because CreateButtons() was called only from GOButtonCreator subclasses where the button definitions were known, this PR makes passing the button definitions to CreateButtons() directly. It makes GetButtonDefinitionList() unnecessary.
It also renames the
m_element_typesmembers in the subclasses to BUTTON_DEFS and makes the static variables in their cpp files.It is only refactoring. No GO behavior should be changed.