-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python < 3.6 #191
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Christian Heimes <[email protected]>
Why wouldn't I skip this and go straight to: |
This PR is pretty much safe, does not introduce any nasty C bugs, and removes all Python 2 related quirks. PR #187 doesn't remove all Python 2 code. There is also a possibility that it introduces C bugs or ref leaks. It needs a thorough review. |
Programming Language :: Python :: 2 | ||
Programming Language :: Python :: 2.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that you drop support for Python 2.7 explicitly, I guess it's perfectly valid to release it as 1.14.0 (contrary to what I originally wrote in #189 (comment)). I realized that pip will not install 1.14.0 in a Python 2.7 environment if the support is dropped explicitly.
Thanks a lot for this change ❤ - I fully support it (but you do not have to listen to a n00b like me 😉)
Such PR essentially removing this amount of compatibility boilerplate and still passing the test suite for python 3.6-3.10 and pypy can only be approved! Looks Very Good To Me. I also vouch to integrate this separately from #187 for the sake of the VCS sanity. |
Taking a look at this, and testing against Python 3.11a6, wrapt fails to install on Python 3.11 due to |
Version 1.14.0 of wrapt deals with Python 3.11 changes. This PR would need to be rebased against that. |
Signed-off-by: Christian Heimes [email protected]