Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ShadowExtension.component #956

Merged
merged 11 commits into from
Sep 17, 2024
Merged

Deprecate ShadowExtension.component #956

merged 11 commits into from
Sep 17, 2024

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Sep 3, 2024

Closes #945.


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

@Goooler Goooler changed the title Fix configuring publishing before shadowJar Deprecated ShadowExtension Sep 13, 2024
@Goooler Goooler changed the title Deprecated ShadowExtension Deprecate ShadowExtension Sep 13, 2024
@Goooler Goooler changed the title Deprecate ShadowExtension Deprecate ShadowExtension.component Sep 13, 2024
@Goooler Goooler marked this pull request as ready for review September 13, 2024 08:30
@Goooler Goooler merged commit fa21300 into main Sep 17, 2024
9 checks passed
@Goooler Goooler deleted the g/fix-945 branch September 17, 2024 12:45
@Goooler
Copy link
Member Author

Goooler commented Sep 17, 2024

@johnrengelman Thanks for the prototype! I believe this is what you expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuring publishing before shadowJar publishes jar with wrong configuration
2 participants