Change names of files with the same path #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanged name e.g. MANIFEST.MF -> MANIFEST-junit-3.8.1.MF
|
try killing your Gradle daemon: |
|
Tests fixed. Could you check this now, and maybe merge? |
|
Two things right away,
|
|
Hmm... I thought transformers need explicit list of files to transform, but as far as I can see now, it's possible for transformer to handle every file it wants (i.e. each file is actually going to transformer). I'll change it to transformer then. Should I create new fork? This one is already quite long. |
|
Can you debug it somehow? I can't connect with remote degugging to running gradle test, nor can debug it in IDEA (ShadowCopyAction.groovy:70: Cannot cast object 'org.apache.tools.zip.ZipOutputStream@2f62c922' with class 'org.apache.tools.zip.ZipOutputStream' to class 'org.apache.tools.zip.ZipOutputStream' - must be from different classloaders.) |
codefromthecrypt
pushed a commit
to openzipkin/zipkin
that referenced
this pull request
Jan 4, 2016
The shadowJar plugin makes a single file out of all the dependencies of our services. Occasionally, this leads to file conflicts. Jackson's META-INF/LICENSE conflicts with the directory META-INF/license While we can run the shadowJars, you cannot extract them with `jar -x`, as it ends up with an IOException extracting META-INF/license. This excludes Jackson's META-INF/LICENSE, until we have a better solution, ideally with one of the proposals in the shadow jar project. See GradleUp/shadow#86 See GradleUp/shadow#102
Fiouz
added a commit
to Fiouz/shadow
that referenced
this pull request
Aug 30, 2021
Omitting the visibility modifier in Groovy [1] automatically creates a
private backing field and a public getter (+ setter if the field is not
final).
It is unlikely to be an intended design as it makes access to those
fields awkward from statically typed languages
`ShadowBasePlugin.getCONFIGURATION_NAME()`.
This is a backward incompatible change as this removes public getters.
Here is what the generated class looked liked before this
commit (7.0.0):
```
$ javap -p -c -constants ShadowBasePlugin.class
Compiled from "ShadowBasePlugin.groovy"
public class com.github.jengelman.gradle.plugins.shadow.ShadowBasePlugin implements org.gradle.api.Plugin<org.gradle.api.Project>, groovy.lang.GroovyObject {
private static final java.lang.String EXTENSION_NAME = "shadow";
private static final java.lang.String CONFIGURATION_NAME = "shadow";
[...]
public static java.lang.String getEXTENSION_NAME();
Code:
0: getstatic GradleUp#86 // Field EXTENSION_NAME:Ljava/lang/String;
3: areturn
public static java.lang.String getCONFIGURATION_NAME();
Code:
0: getstatic GradleUp#111 // Field CONFIGURATION_NAME:Ljava/lang/String;
3: areturn
```
[1] https://groovy-lang.org/objectorientation.html#fields
Fiouz
added a commit
to Fiouz/shadow
that referenced
this pull request
Aug 30, 2021
Omitting the visibility modifier creates a Groovy _property_ [1], which
is composed by:
* a _private_ backing field
* a public getter
* (+ setter if the property is not `final`)
It is unlikely to be an intended design as it makes access to those
fields awkward from statically typed languages
`ShadowBasePlugin.getCONFIGURATION_NAME()`.
This commit replaces such _properties_ with _public fields_ only.
This is a backward incompatible change as this removes public getters.
Here is what the generated class looked liked before this
commit (7.0.0):
```
$ javap -p -c -constants ShadowBasePlugin.class
Compiled from "ShadowBasePlugin.groovy"
public class com.github.jengelman.gradle.plugins.shadow.ShadowBasePlugin implements org.gradle.api.Plugin<org.gradle.api.Project>, groovy.lang.GroovyObject {
private static final java.lang.String EXTENSION_NAME = "shadow";
private static final java.lang.String CONFIGURATION_NAME = "shadow";
[...]
public static java.lang.String getEXTENSION_NAME();
Code:
0: getstatic GradleUp#86 // Field EXTENSION_NAME:Ljava/lang/String;
3: areturn
public static java.lang.String getCONFIGURATION_NAME();
Code:
0: getstatic GradleUp#111 // Field CONFIGURATION_NAME:Ljava/lang/String;
3: areturn
```
[1] https://groovy-lang.org/objectorientation.html#properties
Fiouz
added a commit
to Fiouz/shadow
that referenced
this pull request
Aug 30, 2021
Omitting the visibility modifier creates a Groovy _property_ [1], which
is composed by:
* a _private_ backing field
* a public getter
* (+ setter if the property is not `final`)
It is unlikely to be an intended design as it makes access to those
fields awkward from statically typed languages
`ShadowBasePlugin.getCONFIGURATION_NAME()`.
This commit replaces such _properties_ with _public fields_ only.
This is a backward incompatible change as this removes public getters.
Here is what the generated class looked liked before this
commit (7.0.0):
```
$ javap -p -c -constants ShadowBasePlugin.class
Compiled from "ShadowBasePlugin.groovy"
public class com.github.jengelman.gradle.plugins.shadow.ShadowBasePlugin implements org.gradle.api.Plugin<org.gradle.api.Project>, groovy.lang.GroovyObject {
private static final java.lang.String EXTENSION_NAME = "shadow";
private static final java.lang.String CONFIGURATION_NAME = "shadow";
[...]
public static java.lang.String getEXTENSION_NAME();
Code:
0: getstatic GradleUp#86 // Field EXTENSION_NAME:Ljava/lang/String;
3: areturn
public static java.lang.String getCONFIGURATION_NAME();
Code:
0: getstatic GradleUp#111 // Field CONFIGURATION_NAME:Ljava/lang/String;
3: areturn
```
[1] https://groovy-lang.org/objectorientation.html#properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are two files with the same path in two merged .jar files, e.g.
junit-3.8.1.jar: /LICENSE.TXT
hamcrest-1.3.jar: /LICENSE.TXT
don't overwrite one file with another, but include both in shadow jar with changed names:
/LICENSE-junit-3.8.1.TXT
/LICENSE-hamcrest-1.3.TXT
I have some problems with tests, but... when I rewinded back to commit 30a696d (onto which I rebased my changes) or even 43fe990 (the one that was HEAD when I forked this repository) and issued "./gradlew clean test" I still have the same problems.
It is quite random, and must be connected with classloaders: