Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Gradle 8.0 #822

Merged
merged 7 commits into from
Feb 25, 2023
Merged

Support Gradle 8.0 #822

merged 7 commits into from
Feb 25, 2023

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Feb 23, 2023

Closes #820.

@Goooler Goooler mentioned this pull request Feb 23, 2023
Closed
@Goooler
Add missing HashUtil & HashValue
10e3249
@Goooler
Migrate properties
9116f4b 
- destinationDir to destinationDirectory
- archivePath to archiveFile
- baseName to archiveBaseName
- classifier to archiveClassifier
- version to archiveVersion
- extension to archiveExtension
@Goooler Goooler force-pushed the gradle8 branch 4 times, most recently from 3051b64 to 119b41e Compare February 23, 2023 15:53
@Goooler Goooler mentioned this pull request Feb 23, 2023
Merged
@johnrengelman johnrengelman added this to the 8.0 milestone Feb 25, 2023
@johnrengelman johnrengelman merged commit ac820dd into GradleUp:master Feb 25, 2023
@Goooler Goooler deleted the gradle8 branch February 25, 2023 00:46
@iSE-Timur-Ugurlu
Copy link

iSE-Timur-Ugurlu commented Feb 27, 2023 •
edited
Loading

Still getting a classifier error with 8.0.0 🤷‍♂️

Caused by: org.gradle.api.InvalidUserDataException: You can't map a property that does not exist: propertyName=classifier
        at org.gradle.internal.extensibility.ConventionAwareHelper.map(ConventionAwareHelper.java:59)
        at org.gradle.internal.extensibility.ConventionAwareHelper.map(ConventionAwareHelper.java:93)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at com.github.jengelman.gradle.plugins.shadow.ShadowJavaPlugin$_configureShadowTask_closure1.doCall(ShadowJavaPlugin.groovy:44)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at com.github.jengelman.gradle.plugins.shadow.ShadowJavaPlugin.configureShadowTask(ShadowJavaPlugin.groovy:43)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at com.github.jengelman.gradle.plugins.shadow.ShadowJavaPlugin.apply(ShadowJavaPlugin.groovy:32)
        at com.github.jengelman.gradle.plugins.shadow.ShadowJavaPlugin.apply(ShadowJavaPlugin.groovy)
        at org.gradle.api.internal.plugins.ImperativeOnlyPluginTarget.applyImperative(ImperativeOnlyPluginTarget.java:43)
        at org.gradle.api.internal.plugins.RuleBasedPluginTarget.applyImperative(RuleBasedPluginTarget.java:51)
        at org.gradle.api.internal.plugins.DefaultPluginManager.addPlugin(DefaultPluginManager.java:187)
        at org.gradle.api.internal.plugins.DefaultPluginManager.access$100(DefaultPluginManager.java:52)
        at org.gradle.api.internal.plugins.DefaultPluginManager$AddPluginBuildOperation.run(DefaultPluginManager.java:282)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:29)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$1.execute(DefaultBuildOperationRunner.java:26)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:66)
        at org.gradle.internal.operations.DefaultBuildOperationRunner$2.execute(DefaultBuildOperationRunner.java:59)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:157)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.execute(DefaultBuildOperationRunner.java:59)
        at org.gradle.internal.operations.DefaultBuildOperationRunner.run(DefaultBuildOperationRunner.java:47)
        at org.gradle.internal.operations.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:68)
        at org.gradle.api.internal.plugins.DefaultPluginManager.lambda$doApply$0(DefaultPluginManager.java:167)
        at org.gradle.configuration.internal.DefaultUserCodeApplicationContext.apply(DefaultUserCodeApplicationContext.java:44)
        at org.gradle.api.internal.plugins.DefaultPluginManager.doApply(DefaultPluginManager.java:166)
        ... 281 more

@Goooler
Copy link
Member Author

Goooler commented Feb 27, 2023 •
edited
Loading

It might be used in your shadowJar configurations, not in this plugin, you can ref 9116f4b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

Support Gradle 8
3 participants
@Goooler @iSE-Timur-Ugurlu @johnrengelman