Make sure the plugin can be used with Gradle 7 #624
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle 7 removes the `maven` plugin so even if you compile with an older
version and have the types available, it's possible that they are missing
at runtime.
To workaround this, this commit uses `pluginManager.withPlugin('maven')`
instead which doesn't need any type available on classpath.
4 tasks
johnrengelman
approved these changes
Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle 7 removes the
mavenplugin so even if you compile with an olderversion and have the types available, it's possible that they are missing
at runtime.
To workaround this, this commit uses
pluginManager.withPlugin('maven')instead which doesn't need any type available on classpath.