#609 Support application mainClass property as fallback of mainClassName #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we get this merged? |
yatsvic
approved these changes
Dec 18, 2020
|
Also fixes #625 |
ArcticLampyrid
approved these changes
Jan 6, 2021
|
@johnrengelman please 🙏 |
|
Next one stumbling over this unsolved deprecation. |
johnrengelman
approved these changes
Feb 21, 2021
|
@johnrengelman Thanks! |
NiccoMlt
added a commit
to NiccoMlt/sample-gradle-project
that referenced
this pull request
Mar 26, 2021
waiting for fix from PR GradleUp/shadow#612 to be released in a new version of com.github.johnrengelman.shadow
NiccoMlt
added a commit
to NiccoMlt/sample-gradle-project
that referenced
this pull request
Mar 26, 2021
waiting for fix from PR GradleUp/shadow#612 to be released in a new version of com.github.johnrengelman.shadow
NiccoMlt
added a commit
to NiccoMlt/sample-javafx-project
that referenced
this pull request
Mar 26, 2021
waiting for fix from PR GradleUp/shadow#612 to be released in a new version of com.github.johnrengelman.shadow (cherry picked from commit 4122bbf7fc8eaca494129dc65f3e380f331f6581)
|
We also need a new release now ;) |
FilippoGurioli
pushed a commit
to matteosusca/OOP21-Mtl-Shot
that referenced
this pull request
May 20, 2022
waiting for fix from PR GradleUp/shadow#612 to be released in a new version of com.github.johnrengelman.shadow (cherry picked from commit 4122bbf7fc8eaca494129dc65f3e380f331f6581)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #609
Hello,
Starting from Gradle 6.7,
application.mainClassNameproperty is deprecated.application.mainClass(introduced in Gradle 6.4) is the property to use.The goal of this pull request is to allow projects using shadow plugin to transition to this new property. This change has been done to be non breaking by still picking first
mainClassNameand usingmainClassas a fall-back.This way, older configurations with
mainClassNamewill still works as previously, but newer configurations withmainClasswill also works.One thing to note. This change won't produce an error for newer configurations any more. It won't produce a warning while the shadow plugin will be using Gradle 6.6.
It will still produce a warning when the shadow plugin Gradle version is upgraded to 6.7. To prevent such warning,
mainClassproperty has to be picked beforemainClassNameproperty, but that would apply a small change in the behaviour of the plugin.If maintainers of this plugin prefer to perform directly a change that won't produce a warning in the latter case, I'm open to adapt this pull request.
Feel free to comment this pull request, I will adapt the code based on the received comments. Please note this is my first pull request on this plugin, and my first pull request on any Gradle plugin so apply any special care you would in such case.
Kind regards
Additional information:
edit: I'm sorry for the force push (with lease), the user was wrongly configured.