Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate SimpleRelocator to using lazy properties #1047

Merged
merged 11 commits into from
Nov 27, 2024
Merged

Migrate SimpleRelocator to using lazy properties #1047

merged 11 commits into from
Nov 27, 2024

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Nov 26, 2024 •
edited
Loading

  • CHANGELOG's "Unreleased" section has been updated, if applicable.

Base automatically changed from g/lazy-properties to main November 27, 2024 05:02
@Goooler Goooler force-pushed the g/migrate-simple-relocator-to-lazy branch from bfadcf2 to 2db76dc Compare November 27, 2024 05:11
@Goooler Goooler force-pushed the g/migrate-simple-relocator-to-lazy branch from 2db76dc to 94f673b Compare November 27, 2024 12:30
@Goooler Goooler marked this pull request as ready for review November 27, 2024 12:36
@Goooler Goooler requested a review from Copilot November 27, 2024 12:50
Copilot
Copilot AI reviewed Nov 27, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 7 changed files in this pull request and generated no suggestions.

Files not reviewed (6)
  • api/shadow.api: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/relocation/SimpleRelocator.kt: Language not supported
  • src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.kt: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/relocation/SimpleRelocatorParameterTest.groovy: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/relocation/SimpleRelocatorTest.groovy: Language not supported
  • src/test/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/Log4j2PluginsCacheFileTransformerSpec.groovy: Language not supported
@Goooler Goooler enabled auto-merge (squash) November 27, 2024 12:56
@Goooler Goooler disabled auto-merge November 27, 2024 12:58
@Goooler Goooler enabled auto-merge (squash) November 27, 2024 12:58
@Goooler Goooler merged commit 59676b7 into main Nov 27, 2024
7 checks passed
@Goooler Goooler deleted the g/migrate-simple-relocator-to-lazy branch November 27, 2024 12:58
Goooler added a commit that referenced this pull request Nov 28, 2024
@Goooler
Revert "Migrate SimpleRelocator to using lazy properties (#1047)"
1b58258 
This reverts commit 59676b7
@Goooler Goooler mentioned this pull request Nov 28, 2024
Merged
1 task
Goooler added a commit that referenced this pull request Nov 28, 2024
@Goooler
Revert changes in SimpleRelocator (#1052)
b173e91 
* Revert "Migrate SimpleRelocator to using lazy properties (#1047)"

This reverts commit 59676b7

* Still rename isRawString to rawString

* Optimize normalizePatterns

* Mark pattern and shadedPattern non-null

* Inline getters

* Note this change

* Revert "Inline getters"

This reverts commit b05bc7d.
@Goooler Goooler mentioned this pull request Dec 2, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Goooler