New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs are wrong regarding `inheritFrom` #251

Closed

johnrengelman opened this issue Sep 27, 2016 · 1 comment

Labels

Milestone

Collaborator

johnrengelman commented Sep 27, 2016

inheritFrom requires specifying jar.manifest
https://github.com/johnrengelman/shadow/blob/5a80aa3aef898511d027d154a9732e55a5851d34/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.groovy#L48

But the docs omit this: https://github.com/johnrengelman/shadow/blob/master/src/docs/asciidoc/10-configuring.adoc

The text was updated successfully, but these errors were encountered:

Contributor

melix commented Sep 27, 2016

👍

johnrengelman added enhancement documentation and removed enhancement labels

johnrengelman added this to the 1.2.4 milestone

johnrengelman added a commit that referenced this issue


          Fix #251

7fb8438

johnrengelman closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment