Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump Java level to 11" #1011

Merged
merged 4 commits into from
Nov 3, 2024
Merged

Revert "Bump Java level to 11" #1011

merged 4 commits into from
Nov 3, 2024

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Nov 3, 2024 •
edited
Loading

  • CHANGELOG's "Unreleased" section has been updated, if applicable.

@Goooler Goooler merged commit f991608 into main Nov 3, 2024
8 checks passed
@Goooler Goooler deleted the g/revert-java-11 branch November 3, 2024 00:53
skmedix
skmedix reviewed Nov 3, 2024
View reviewed changes
Copy link

@skmedix skmedix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goooler This is not enough, if you want to keep Java 8 compatibility, you have to downgrade jdependency too, as shadow already partly requires java 11 since https://github.com/GradleUp/shadow/releases/tag/8.3.2

@Goooler
Copy link
Member Author

Goooler commented Nov 3, 2024

We can't revert that since tcurdt/jdependency#294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skmedix skmedix skmedix left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requires Java 11
2 participants
@Goooler @skmedix