Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new release for Java 23 #294

Closed
Goooler opened this issue Sep 18, 2024 · 6 comments
Closed

A new release for Java 23 #294

Goooler opened this issue Sep 18, 2024 · 6 comments

Comments

@Goooler
Copy link
Contributor

Goooler commented Sep 18, 2024

Java 23 is out.

https://openjdk.org/projects/jdk/23/

@tcurdt
Copy link
Owner

tcurdt commented Sep 18, 2024

There are no dependency updates yet and the build matrix passes.
I am not sure what needs to be done for this.

@Goooler
Copy link
Contributor Author

Goooler commented Sep 18, 2024

As you shaded ASM for this lib, the bundled one is still lower ASM 9.7, which doesn't support Java 23 yet.

Caused by: java.lang.IllegalArgumentException: Unsupported class file major version 67	
	at org.vafer.jdeb.shaded.objectweb.asm.ClassReader.<init>(ClassReader.java:200)	
	at org.vafer.jdeb.shaded.objectweb.asm.ClassReader.<init>(ClassReader.java:180)	
	at org.vafer.jdeb.shaded.objectweb.asm.ClassReader.<init>(ClassReader.java:166)	
	at org.vafer.jdeb.shaded.objectweb.asm.ClassReader.<init>(ClassReader.java:288)	
	at org.vafer.jdependency.Clazzpath.addClazzpathUnit(Clazzpath.java:179)	
	at org.vafer.jdependency.Clazzpath.addClazzpathUnit(Clazzpath.java:130)	
	at org.vafer.jdependency.Clazzpath.addClazzpathUnit(Clazzpath.java:106)	
	at org.vafer.jdependency.Clazzpath.addClazzpathUnit(Clazzpath.java:97)	
	at org.vafer.jdependency.Clazzpath$addClazzpathUnit.call(Unknown Source)	
	at com.github.jengelman.gradle.plugins.shadow.internal.UnusedTracker$_closure1.doCall$original(UnusedTracker.groovy:22)

In this case, may need to release a new version after each ASM update.

@tcurdt
Copy link
Owner

tcurdt commented Sep 18, 2024

Correct. But AFAICS there no ASM update yet.

@Goooler
Copy link
Contributor Author

Goooler commented Sep 18, 2024

It's #239, which has been merged after jdependency-2.10.

I still suggest we can avoid shading ASM, to get updates easier in consumer sides.

@tcurdt
Copy link
Owner

tcurdt commented Sep 18, 2024

Ah, somehow forgot to release. Just pushed 2.11 to maven central.

@tcurdt tcurdt closed this as completed Sep 18, 2024
@Goooler
Copy link
Contributor Author

Goooler commented Sep 18, 2024

Thanks, it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants