Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compatibility with sqlalchemy 1.4 #80

Closed
wants to merge 1 commit into from
Closed

fix compatibility with sqlalchemy 1.4 #80

wants to merge 1 commit into from

Conversation

marillat
Copy link
Contributor

@marillat marillat commented Dec 9, 2021 •
edited
Loading

Fix for #79
First time I use sqlalchemy and I don't sure if this patch is correct.

@marillat marillat mentioned this pull request Dec 9, 2021
Closed
@marillat
Copy link
Contributor Author

marillat commented Dec 9, 2021

line 744 return select(*make_simple_select_arg(criteria,table)) should not work as func.count isn't called.

The only call I see with criteria is in /usr/lib/python3/dist-packages/gourmand/plugins/field_editor/fieldEditor.py

@flochir flochir mentioned this pull request Feb 7, 2022
Merged
@cydanil
Copy link
Contributor

cydanil commented Jun 19, 2022

Thanks, this was done elsewhere :)

@cydanil cydanil closed this Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marillat @cydanil