Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update Gtk API calls in key editor #54

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

cydanil
Copy link
Contributor

@cydanil cydanil commented Oct 10, 2021

Description

This PR fixes the launching the key editor: first by updating GTK API calls from GtkComboBoxEntry to GtkComboBoxText, and second

How Has This Been Tested?

This was tested by changing keys, items, and units of various ingredients, both one at a time and several at once.
Searching for either of keys, items, and units was also tested.

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2021

This pull request introduces 1 alert and fixes 1 when merging 26ecf2e into 1d43a22 - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2021

This pull request fixes 1 alert when merging 0575567 into 1d43a22 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@cydanil cydanil marked this pull request as ready for review October 15, 2021 13:35
@cydanil cydanil merged commit 864e16e into GourmandRecipeManager:main Oct 15, 2021
@cydanil cydanil deleted the fix/50 branch October 15, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant