-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated code #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was tested by importing a web recipe
This pull request introduces 3 alerts and fixes 17 when merging 0d3be90 into 3f872a4 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert and fixes 19 when merging f97db2c into 3f872a4 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request fixes 28 alerts when merging 4949552 into 3f872a4 - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issues found in code analysis, mostly relating to the deprecated
tempfile.mktemp
.Some deprecated code was also removed: not only are they broken, but have been already replaced by tests run by the CI (#2 .)
How Has This Been Tested?
The tests, as well as ensuring that each of the touched functionalities each keep working as intended within the application.
Screenshots (if appropriate):
Types of changes
Checklist: