Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pillow 8.3.2 minimum #28

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

cydanil
Copy link
Contributor

@cydanil cydanil commented Sep 3, 2021

Description

This resolves issue where Pillow would crash when imported after Gtk.

How Has This Been Tested?

This was tested manually, as I had described on the pillow project:

Thanks, I also encountered a similar issue with pillow==8.3.1 and PyGObject==3.40.1.

I could reduce it down to the code below:

import gi
from gi.repository import Gtk, Gdk, GdkPixbuf
from PIL import ImageDraw

which would segfault.

Modifying this excerpt by importing pillow first resolved the issue:

import gi
from PIL import ImageDraw
from gi.repository import Gtk, Gdk, GdkPixbuf

With pillow==8.3.0, the order does not matter and the code runs fine.
The wheel linked above also resolves the issue in my case!

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

This resolves issue where Pillow would crash when imported after Gtk
@cydanil cydanil merged commit 575d43a into GourmandRecipeManager:main Sep 3, 2021
@cydanil cydanil deleted the feat/pillow_8.3.2 branch September 3, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant