Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mkstemp usage #12

Merged
merged 3 commits into from
Aug 3, 2021
Merged

Fix mkstemp usage #12

merged 3 commits into from
Aug 3, 2021

Conversation

cydanil
Copy link
Contributor

@cydanil cydanil commented Aug 3, 2021

Description

This PR fixes mkstemp usage and extracts the filename from the returned (fd, fn) tuple.

How Has This Been Tested?

This was tested by saving the ingredient list to file, and printing it to pdf.
PDF printing of a recipe was also tested.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cydanil cydanil merged commit b2428d2 into GourmandRecipeManager:main Aug 3, 2021
@cydanil cydanil deleted the fix/mkstemp branch August 3, 2021 20:44
@cydanil cydanil mentioned this pull request Aug 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cydanil