Treat priority as an arbitrary string #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This matches what TaskWarrior does: priority is a UDA, and can be redefined by the user's local config.
dbr
approved these changes
Apr 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches what TaskWarrior does: priority is a UDA, and can be
redefined by the user's local config.
I dislike this decision, as it means that anything interpreting a task has to either know the user's UDA configurations (and at this point, configuration is not replicated, so that's a local setting); or guess that "L", "M", and "H" mean what they usually do. But, it's how TW works so we'll stick with it.
@miguelpduarte this will touch similar bits of the code to #348, if you'd like to take a look.