Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created IN.py #106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Created IN.py #106

wants to merge 1 commit into from

Conversation

mohammmmmmmmmmed
Copy link

No description provided.

lauft
lauft requested changes Aug 4, 2024
View reviewed changes
Copy link
Member

@lauft lauft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohammmmmmmmmmed Thanks for your contribution. However, I am not sure whether this PR is already complete. Will you add more details later? 🤔

src/holidata/holidays/IN.py
.on("12-25") \
.with_flags("NRF")

# Placeholder for additional holidays to be added later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are holidays left out, add a comment to the class, but not an actual holiday definition which will end up in the output.

src/holidata/holidays/IN.py
# https://www.officeholidays.com/countries/india/
# https://www.calendarlabs.com/holidays/india/
#
# This is a placeholder class for India holidays. More details will be added later.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this is currently just a draft? 🤔

@lauft
Copy link
Member

lauft commented Aug 10, 2024

Apart from my review comments:

  • Please rebase your branch to the current HEAD of this repository (this fixes the failing pre-commit.ci check)
  • Add your locale to holidata/holidays/init.py, sorted alphabetically into the list, rerun pytest tests/test_holidata.py --update-snapshots to create the snapshots, and add those (and only those) to your PR. (If any other tests are red or have to be modified, that's an error 😉)

@lauft
Copy link
Member

lauft commented Aug 17, 2024

@mohammmmmmmmmmed I have dropped the dependency to snapshottest in favor of syrupy; the latter seems better maintained and already supports Python 3.12.

This makes it mandatory to rebase your PR before adding the snapshot files for your locale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauft lauft lauft requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammmmmmmmmmed @lauft