[WIP] Allow limitless description and annotation lengths (option B) Resolve #441. #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is presented as an alternative to GothenburgBitFactory#436. This could lead to more-difficult-to-debug errors if people pass no value to other configuration options, because the error will likely be in bugwarrior failing to handle None rather than ConfigParser raising a validation error on their config file. However, I don't see a clear alternative. I did play around with subclassing ConfigParser to just allow no value for integers, but the extra complication might not be worth it.
ryneeverett
changed the title
|
According to this comment my use of |
As @coddingtonbear (our local ini file expert) pointed out, `allow_no_value=True` allows the omission of the equals sign; omitting a value is permitted by default.
ryneeverett
changed the title
ryneeverett
changed the title
|
Good thing I tried to test this. I should have realized that I still need the modified version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is presented as another alternative to #436.
This could lead to more-difficult-to-debug errors if people pass noSee second commit.value to other configuration options, because the error will likely be
in bugwarrior failing to handle None rather than ConfigParser raising a
validation error on their config file. However, I don't see a clear
alternative. I did play around with subclassing ConfigParser to just
allow no value for integers, but the extra complication might not be
worth it.