Use exit code 1 on failure when pulling #1047
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
pull
command returns 0 even when a failure occurred.My usecase is having this running in a systemd timer job and every now and then it happens, that I shutdown my machine while there is a pull command running. This results in a lockfile being present which prevent future runs from succeeding.
However, since that case is caught in an exception there is the error output, but the job itself returns success (exit code 0).
This PR exits with code 1 as done in
_try_load_config
, as this was the simplest to implement. Maybe a nicer approach would be to raise aSystemExit
instead but that will not directly put it to the critical log. Please let me know what you would prefer.