Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AMP PHP toolbox from Packagist #5291

Closed
wants to merge 1 commit into from
Closed

Conversation

swissspidy
Copy link
Collaborator

Summary

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions


See #4897

@swissspidy swissspidy added Type: Infrastructure Changes impacting testing infrastructure or build tooling Group: WordPress Changes related to WordPress or Gutenberg integration AMP Output Issues related to AMP output and validation Pod: WP & Infra labels Nov 13, 2020
@google-cla google-cla bot added the cla: yes label Nov 13, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2020

Size Change: 0 B

Total Size: 1.36 MB

ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 876 B 0 B
assets/css/stories-dashboard.css 319 B 0 B
assets/css/web-stories-embed-block.css 615 B 0 B
assets/js/chunk-fonts-********************.js 44.5 kB 0 B
assets/js/chunk-web-stories-template-0-********************.js 11 kB 0 B
assets/js/chunk-web-stories-template-1-********************.js 11.3 kB 0 B
assets/js/chunk-web-stories-template-2-********************.js 10.9 kB 0 B
assets/js/chunk-web-stories-template-3-********************.js 10.5 kB 0 B
assets/js/chunk-web-stories-template-4-********************.js 12.7 kB 0 B
assets/js/chunk-web-stories-template-5-********************.js 7.12 kB 0 B
assets/js/chunk-web-stories-template-6-********************.js 10.2 kB 0 B
assets/js/chunk-web-stories-template-7-********************.js 10.1 kB 0 B
assets/js/chunk-web-stories-textset-0-********************.js 5.25 kB 0 B
assets/js/chunk-web-stories-textset-1-********************.js 6.79 kB 0 B
assets/js/chunk-web-stories-textset-2-********************.js 7.83 kB 0 B
assets/js/chunk-web-stories-textset-3-********************.js 15.2 kB 0 B
assets/js/chunk-web-stories-textset-4-********************.js 4.38 kB 0 B
assets/js/chunk-web-stories-textset-5-********************.js 5.68 kB 0 B
assets/js/chunk-web-stories-textset-6-********************.js 5.47 kB 0 B
assets/js/chunk-web-stories-textset-7-********************.js 10.3 kB 0 B
assets/js/edit-story.js 607 kB 0 B
assets/js/stories-dashboard.js 466 kB 0 B
assets/js/web-stories-activation-notice.js 74 kB 0 B
assets/js/web-stories-embed-block.js 17.4 kB 0 B

compressed-size-action

@spacedmonkey
Copy link
Contributor

@swissspidy This PR is in draft. Should I review it. Can you explain the PR a little more in the description?

@swissspidy
Copy link
Collaborator Author

@spacedmonkey Nothing to review just yet. Just wanted to make you aware of it after the Slack discussion on Friday about the AMP integration. Will revisit after AMP 2.0.6 drops.

@bmattb bmattb added this to the Super Sprint 44 milestone Dec 14, 2020
@swissspidy swissspidy added the Status: Blocked On hold for the time being label Dec 23, 2020
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #5291 (8006838) into main (bb40603) will increase coverage by 5.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5291      +/-   ##
==========================================
+ Coverage   70.29%   76.23%   +5.93%     
==========================================
  Files        1057      964      -93     
  Lines       18915    16939    -1976     
==========================================
- Hits        13296    12913     -383     
+ Misses       5619     4026    -1593     
Flag Coverage Δ
karmatests 52.57% <ø> (+11.84%) ⬆️
unittests 66.38% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
includes/Story_Renderer/HTML.php 77.77% <ø> (-3.40%) ⬇️
assets/src/edit-story/components/switch/index.js 0.00% <0.00%> (-83.34%) ⬇️
...ry/components/library/panes/media/common/styles.js 44.44% <0.00%> (-55.56%) ⬇️
.../design-system/components/typography/text/index.js 60.00% <0.00%> (-40.00%) ⬇️
...dit-story/components/mediaPicker/useMediaPicker.js 60.00% <0.00%> (-36.30%) ⬇️
includes/REST_API/Stories_Base_Controller.php 40.98% <0.00%> (-24.60%) ⬇️
includes/Decoder.php 77.77% <0.00%> (-22.23%) ⬇️
assets/src/animation/effects/rotateIn/index.js 0.00% <0.00%> (-18.19%) ⬇️
assets/src/edit-story/utils/localStore.js 85.71% <0.00%> (-14.29%) ⬇️
includes/REST_API/Embed_Controller.php 82.02% <0.00%> (-13.98%) ⬇️
... and 585 more

@swissspidy
Copy link
Collaborator Author

Combining with #5344

@swissspidy swissspidy closed this Feb 4, 2021
@swissspidy swissspidy deleted the try/amp-toolbox branch February 4, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMP Output Issues related to AMP output and validation Group: WordPress Changes related to WordPress or Gutenberg integration Status: Blocked On hold for the time being Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants