Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing title dialog #4251

Merged
merged 15 commits into from
Sep 8, 2020
Merged

Add missing title dialog #4251

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
db899b7
Added a new dialog in case story title is missing
Aug 27, 2020
9c31b71
Added infrastructure to access title input
Aug 27, 2020
0647682
Updated wording and layout of dialog
Sep 1, 2020
f70937a
Merge branch 'main' into add/4184-missing-title-dialog
Sep 3, 2020
800b010
Refactored header buttons to multiple files
Sep 3, 2020
18c11d7
Fixed link and formatting
Sep 3, 2020
da6a333
Amended unit tests of publish button with new feature
Sep 4, 2020
3c8dc29
Updated unit tests to cover even more cases
Sep 4, 2020
a902270
Added onClose to titleMissingDialog
Sep 4, 2020
8a2106a
Added storybook story for `titleMissingDialig`
Sep 4, 2020
a63b77a
Added karma test with screenshot for missing title dialog
Sep 4, 2020
d6e18b1
Merge branch 'main' into add/4184-missing-title-dialog
Sep 4, 2020
8779d76
Fixed nit
Sep 8, 2020
9ff66f1
Merge branch 'main' into add/4184-missing-title-dialog
Sep 8, 2020
003279e
Merge branch 'main' into add/4184-missing-title-dialog
swissspidy Sep 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion assets/src/edit-story/components/dialog/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ import { rgba } from 'polished';
*/
import Modal from '../modal';

export const TRANSITION_DURATION = 300;

// Shadow styles ported from @material-ui/Dialog
const DialogBox = styled.div`
border-radius: 4px;
Expand All @@ -40,7 +42,8 @@ const DialogBox = styled.div`
0px 24px 38px 3px ${({ theme }) => rgba(theme.colors.bg.black, 0.14)},
0px 9px 46px 8px ${({ theme }) => rgba(theme.colors.bg.black, 0.12)};
color: ${({ theme }) => rgba(theme.colors.bg.black, 0.87)};
transition: box-shadow 300ms cubic-bezier(0.4, 0, 0.2, 1) 0ms;
transition: box-shadow ${TRANSITION_DURATION}ms cubic-bezier(0.4, 0, 0.2, 1)
0ms;
background-color: ${({ theme }) => theme.colors.fg.white};
`;

Expand Down
354 changes: 0 additions & 354 deletions assets/src/edit-story/components/header/buttons.js
View file
Open in desktop

This file was deleted.

Loading