Dashboard: Settings view context foundation (Publisher Logos) #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrittanyIRL
commented
Jul 8, 2020
| function PublisherLogoSettings() { | ||
|
|
||
| // eslint-disable-next-line no-unused-vars | ||
| function PublisherLogoSettings({ onUpdatePublisherLogo, publisherLogos }) { |
There was a problem hiding this comment.
will use these once OK to connect to fileUpload component. Wanted to pass them through to set up propTypes here.
BrittanyIRL
requested review from
mariano-formidable,
carloskelly13,
dmmulroy and
maxyinger
Codecov Report
@@ Coverage Diff @@
## master #3085 +/- ##
=======================================
Coverage 81.99% 82.00%
=======================================
Files 716 716
Lines 12049 12050 +1
=======================================
+ Hits 9880 9881 +1
Misses 2169 2169
|
|
Size Change: +15 B (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
| return ( | ||
| <PublisherLogoSettings | ||
| onUpdatePublisherLogo={(e) => { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
Will we need to preventDefault for all usages of this logo? If so we could just bubble this up and then wrap the callback.
There was a problem hiding this comment.
nah this is just because there's nothing there yet since the fileUpload is separate and i hate it when storybook clicks send you out of the existing view.
carloskelly13
approved these changes
Jul 8, 2020
maxyinger
approved these changes
Jul 9, 2020
swissspidy
added
the
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We don't have access to an API for this yet, just laying ground work for connecting UI to API via context.
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
useSettingsApi.Addresses #2747