-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Settings view context foundation (Google Analytics) #2976
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2976 +/- ##
==========================================
- Coverage 81.87% 81.16% -0.71%
==========================================
Files 690 716 +26
Lines 10464 12048 +1584
==========================================
+ Hits 8567 9779 +1212
- Misses 1897 2269 +372
|
Size Change: +283 B (0%) Total Size: 1 MB
ℹ️ View Unchanged
|
7a12e6a
to
fae8cc6
Compare
5f7b01e
to
c780811
Compare
adcbe52
to
eaf5d1f
Compare
assets/src/dashboard/app/views/editorSettings/googleAnalytics/index.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment for you to consider 🤔
7d74ddb
to
b295ba3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 1 tiny itty bitty nit that you can freely ignore. Excellent work!
b295ba3
to
e2c4369
Compare
Summary
Setting up hooks for settings data
Relevant Technical Choices
useSettingsApi
that will eventually give us the data we need for accessing google analytics ids (not part of default wordpress settings api)To-do
User-facing changes
Invisible change at the moment
Testing Instructions
addresses #2747